Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate documentation template - delete Camara_Versioning_Guidelines.md #261

Merged

Conversation

rartych
Copy link
Collaborator

@rartych rartych commented Jul 31, 2024

What type of PR is this?

Add one of the following kinds:

  • cleanup

What this PR does / why we need it:

In order to reduce redundancy, all documentation should be embedded within the OAS definition.
The API-DocumentationTemplate.md file is deprecated.

The Camara_Versioning_Guidelines.md was removed in #215 but was restored with zero length with #234.
It is deleted here.

Which issue(s) this PR fixes:

Fixes #260

Special notes for reviewers:

The old issue with decision of Commonalities
camaraproject/WorkingGroups#164

Potentially more detailed guidelines can be created for description field in info object as main documentation location, and for documenting error cases, etc.

Changelog input

The API-DocumentationTemplate.md file is deprecated.
The Camara_Versioning_Guidelines.md was removed.

Copy link
Collaborator

@PedroDiez PedroDiez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@shilpa-padgaonkar shilpa-padgaonkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@shilpa-padgaonkar
Copy link
Collaborator

As our 3rd codeowner @patrice-conil is on vacation, will merge this PR with 2 approvals.

@shilpa-padgaonkar shilpa-padgaonkar merged commit a5728de into camaraproject:main Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove "Release notes" from API-DocumentationTemplate.md
3 participants