Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CAMARA_common.yaml bugs and typos fix #174

Conversation

fernandopradocabrillo
Copy link
Contributor

What type of PR is this?

Add one of the following kinds:

  • bug
  • correction

What this PR does / why we need it:

A few bugs and typos has been detected in the common schemas.

Which issue(s) this PR fixes:

Fixes #173

@rartych
Copy link
Collaborator

rartych commented Apr 23, 2024

LGTM
After merging this, let's look at possible changes to API Design Guidelines indicated in #180

Copy link
Collaborator

@shilpa-padgaonkar shilpa-padgaonkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@shilpa-padgaonkar
Copy link
Collaborator

@PedroDiez and @patrice-conil : Could you kindly review

Copy link
Collaborator

@patrice-conil patrice-conil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@shilpa-padgaonkar
Copy link
Collaborator

@PedroDiez @RubenBG7 Could someone from TEF side kindly review and approve so that this PR can be merged?

Copy link
Collaborator

@PedroDiez PedroDiez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shilpa-padgaonkar shilpa-padgaonkar merged commit b16e944 into camaraproject:main Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

A few bugs and typos in CAMARA_common.yaml
5 participants