Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

carrier_billing_checkout_1-step_model_and_purchases_list #64

Merged

Conversation

PedroDiez
Copy link
Collaborator

@PedroDiez PedroDiez commented Mar 7, 2023

PR

PR to include 1-step payment and List of Purchases:

  • NEW Endpoint to manage 1-step payment -> POST /purchases/{purchase_id}/payment
  • NEW Endpoint to fetch a list of purchases -> GET /purchases

Additionally, related Issues
Issue 54

  • Indication of phone number in Payment Request, as optional input. This does not preclude to always indicate it, if preferred by an specific implementation

Issue 56

  • payment_creation_date and payment_date added in GET endpoints and also notification endpoint

Issue 58

  • Removing pattern from "status" field as being an integer and pattern applies for string fields.

Comm PR 171

  • Input/Output parameters aligned to camelCase

Comm Guidelines

  • Aligment for pagination and indication of x-correlator (Not a MUST to indicate however we want to do so, as a guidance for devs)

Documentation will be updated after yaml agreement.

NOT HANDLED IN THIS PR

Points out of scope of this PR: (To manage in a future PR, just to align at the same level with carrier billing payment)

  • Notifications thread:

camaraproject/WorkingGroups#156
camaraproject/WorkingGroups#173

@PedroDiez
Copy link
Collaborator Author

NOTE: I will take advantage of guidelines update about format used for API input/output params.
To align the proposal with them regarding the use of camelCase: camaraproject/WorkingGroups#171

@PedroDiez
Copy link
Collaborator Author

PedroDiez commented Mar 23, 2023

Now Ready for review. Aligned at functionality level with Carrier Billing Payment v0.7.0

NOTE that notificationAuthToken is only manage in createPurchase. Reason for that is to ensure its confidentiality as much as possible, so no need to return in GET endpoints as the ONLY use for it is in the notifications callback endpoint

Copy link
Collaborator

@bigludo7 bigludo7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good for me !

@PedroDiez PedroDiez merged commit 40feecb into main Apr 13, 2023
@PedroDiez PedroDiez deleted the carrier_billing_checkout_1-step_model_and_purchases_list branch October 10, 2024 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants