Enhancements for Carrier Billing v0.2 - Part I #119
Conversation
PedroDiez
added
documentation
PedroDiez
requested review from
ToshiWakayama-KDDI and
bigludo7
as code owners
|
Thanks @PedroDiez |
|
Hi @bigludo7, Many thanks for the review!. I wanted to add these ones in advance as were easy to manage. |
|
Ready for review: @bigludo7, @rartych, @alabajnaid |
There was a problem hiding this comment.
Current API Design Guidelines states that X-Correlator header is not Required in OAS Definition.
Some clarifications are currently proposed in camaraproject/Commonalities#88
BTW, X-Correlator or x-correlator or more popular header: X-Correlation-ID ?
| requestBody: | ||
| description: Creates a new carrier billing payment notification | ||
| content: | ||
| application/json: |
There was a problem hiding this comment.
Should be: application/cloudevents+json:
There was a problem hiding this comment.
There was a problem hiding this comment.
Yes and here also: camaraproject/Commonalities#86
We have discussed this point in Commonalities call 2 weeks ago and the team was agreed to align with Cloud Events application
There was a problem hiding this comment.
Thanks for clarification!
Hi Rafał, Regarding the fact of not indicating the header in the yaml is not a good approach, because there is no contingency to inform consumers that they can use the header. Consumers do NOT have to know the CAMARA API Design guidelines. Then, for the time being I prefer to keep the "x-correlator" header (HTTP headers are case insensitive). I have already commented in commonalities for alignment |
Co-authored-by: Rafal Artych <[email protected]>
Co-authored-by: Rafal Artych <[email protected]>
What type of PR is this?
Add one of the following kinds:
What this PR does / why we need it:
This PR deals with some Issues whose output is already agreed:
/documentation/API_documentation/Carrier_Billing_API.mdand aligned with current model approach for QoD and Home Devices QoD APIs. Providing details about state transitions -in the current context, without considerations of Issue#116]Which issue(s) this PR fixes:
Fixes #97, #105, #106, #107, #108, #112
Special notes for reviewers:
COMPLETED. Ready for review