-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
blockchain_identification_and_alignment_topics #30
blockchain_identification_and_alignment_topics #30
Conversation
Co-authored-by: Sebastian Köller <[email protected]>
Thanks @grgpapadopoulos, @sebKoeller for the review so far. |
I guess it would be more correct to use the expression "associated with" instead of "associated to" in the descriptions. |
Thanks Rafal!
|
Thanks @grgpapadopoulos, @sebKoeller Will merge it during meeting |
What type of PR is this?
Add one of the following kinds:
What this PR does / why we need it:
This PR is intended to cover:
blockchainNetworkId
defined two exceptions:Which issue(s) this PR fixes:
Fixes #19
Alignment with Commonalities#57
Special notes for reviewers:
Blockchain Identification parameter name set to
blockchainNetworkId