Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

create_changelog_release_v010 #23

Merged
merged 1 commit into from
Oct 6, 2023
Merged

create_changelog_release_v010 #23

merged 1 commit into from
Oct 6, 2023

Conversation

PedroDiez
Copy link
Collaborator

What type of PR is this?

  • subproject management

What this PR does / why we need it:

Update of CHANGELOG.md for the release v0.1.0

The merge commit of this PR will be tagged as release v0.1.0

Which issue(s) this PR fixes:

Fixes #22

Special notes for reviewers:

N/A

@PedroDiez PedroDiez requested review from engst03, rartych, a user and grgpapadopoulos October 3, 2023 15:59
@PedroDiez PedroDiez self-assigned this Oct 3, 2023
@PedroDiez PedroDiez requested review from grgpapadopoulos and a user October 5, 2023 18:54
@PedroDiez
Copy link
Collaborator Author

Seb, Georgios just to kindly ask the approval again as codeowners

@grgpapadopoulos
Copy link
Collaborator

Hello @PedroDiez,
the Changelog link https://github.com/camaraproject/BlockchainPublicAddress/commits/v0.1.0
returns a 404 to me

@PedroDiez
Copy link
Collaborator Author

Hello @PedroDiez, the Changelog link https://github.com/camaraproject/BlockchainPublicAddress/commits/v0.1.0 returns a 404 to me

I think it will work after merging this PR and afterwards generating the tag/release, isn't it @rartych?

grgpapadopoulos
grgpapadopoulos approved these changes Oct 6, 2023
View reviewed changes
Copy link
Collaborator

@grgpapadopoulos grgpapadopoulos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets find out

rartych
rartych approved these changes Oct 6, 2023
View reviewed changes
Copy link
Collaborator

@rartych rartych left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should work after publishing the release.

@PedroDiez
Copy link
Collaborator Author

Thanks guys!!!! Let's go then

@PedroDiez PedroDiez merged commit bff5c69 into main Oct 6, 2023
@PedroDiez PedroDiez added documentation Improvements or additions to documentation subproject management Indicating issues with subproject repository or release management process labels Jan 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grgpapadopoulos grgpapadopoulos grgpapadopoulos approved these changes

@rartych rartych rartych approved these changes

@jordonezlucena jordonezlucena Awaiting requested review from jordonezlucena

@engst03 engst03 Awaiting requested review from engst03

Assignees

@PedroDiez PedroDiez

Labels
documentation Improvements or additions to documentation subproject management Indicating issues with subproject repository or release management process
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Release v0.1.0
3 participants
@PedroDiez @grgpapadopoulos @rartych