Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get repo default branch if --branch not provided (containerapp up --repo) #75

Closed
wants to merge 1 commit into from

Conversation

runefa
Copy link
Collaborator

@runefa runefa commented Apr 25, 2022


This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update src/index.json automatically.
The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify src/index.json.

@panchagnula
Copy link
Collaborator

@StrawnSC please take a look & see if this is something that can be incorporated to --repo / github actions add in general. Please ensure we test this thoroughly before we include this.

@runefa
Copy link
Collaborator Author

runefa commented Apr 25, 2022

Will also need to update the param help @StrawnSC

@panchagnula
Copy link
Collaborator

@haroonf & @StrawnSC this change would also need the update to help as well to not say default is "main"

@runefa runefa changed the title Added prototype for new feature. Get repo default branch if --branch not provided (containerapp up --repo) Apr 25, 2022
@StrawnSC
Copy link
Collaborator

StrawnSC commented May 6, 2022

Rewrote this on Calvin's main and added the help text change here: #93

I tested E2E with up and github-actions add

@StrawnSC StrawnSC closed this May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants