-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(iOS): scroll edge appearance #54
feat(iOS): scroll edge appearance #54
Conversation
5ee5ebf
to
ca3e5f3
Compare
Hmm I don't really see the difference between opaque and transparent. Can we make it a booean? something like: I think setting ( |
Haven't tested opaque clearly but thought it was neat to expose all available options as it was a small effort. |
a13a79a
to
9c5766e
Compare
On the one hand it's neat but on the other it introduces confusion for users. If we have two options that do almost the same then let's make it easier. Probably we need to annotate that |
Is the lazy loading at all needed with this library (perf wise)? As in using it as default... |
It is, if someone renders a huge list in one of the tabs then it can cause issues. Also lazy is the default on JS Tabs so we are matching the "standard". Maybe Im missing why there is transparent and opaque so let's expose it as you mentioned. I would set |
Yes, default is currently our default :) |
77c173e
to
51464bb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this! Two last docs changes
This let's you define the edge appearance of the tabbar.
Allowing for a tabbar that is transparent when there is no content behind the tabbar.
@okwasniewski I am a bit in doubt what we should initially set this to... It seems that if you have a tabbarcontroller it modifies this to transparent by default? Do we want it transparent by default (on the scroll edge) or not... hmm...
If the value of this property is nil, UIKit uses the value of the tab bar’s standardAppearance property, modified to have a transparent background. If no tab bar controller manages your tab bar, UIKit ignores this property and uses the tab bar’s standard appearance.