feat: FS tools + example #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
grabbou
force-pushed
the
feat/fs-tools
branch
from
c8bdd62 to
9c77c8c
Compare
|
Thanks! Going to merge it in, I have a follow-up with a bunch of tweaks (per WhatsApp) |
grabbou
added a commit
that referenced
this pull request
Dec 9, 2024
The example is not the best one. After merging in #56 I think I'll make something more spectacular - indexing local text files would be the best option I guess, or indexing different Wikipedia articles / doing local search - or something like this. @grabbou check the idea I had for switching the backend. I guess per-module global variable as a driver is not the best option, maybe you'd suggest other way handling it - feel free The cool thing is that in this implementation we're dependency free (for the in-memory vector store) so it can be even moved to the core Co-authored-by: Mike Grabowski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.