Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: #99 workflow knowledge #100

Closed
wants to merge 6 commits into from
Closed

Conversation

pkarw
Copy link
Collaborator

@pkarw pkarw commented Dec 11, 2024

Well, I implemented it - #99 - I guess it MIGHT do a good job limiting dispatching offspring (by taking the agent too many context planning tasks) - however, it's pretty damn hard to find it out at the moment. To be perfectly honest, I don't really like it, so it's up to you, @grabbou, if you decide to merge it or not.

I mean - I believe in a better quality change in dispatching only after refactoring and A/B kind of testing different dispatchers on all example probes. Right now, I guess.

I'm not sure about the naming: knowledge - as in the future - knowledge maybe should be something more related to the gathered shared context between the agents. I mean, in the end, it's the same meaning, a different way of how it will work.

@pkarw pkarw requested a review from grabbou December 11, 2024 17:43
@pkarw
Copy link
Collaborator Author

pkarw commented Dec 11, 2024

Note that the backward compatibility mode makes it not compliant with the kind of Liskov Substitution Principle (LSP) and, therefore, more difficult to debug - especially for newcomers.

So if merging in, maybe we should disable backward compatibility and always add only the background to the agents even when it's empty. @grabbou

The other thing is that it's pretty essential to pass this information - till now embedded into description like, for example, file names - otherwise, agents started hallucinating during the tests - inventing file names that don't exist, etc.

…e're sharing for example paths and file names in it - not only kind of background info
@grabbou
Copy link
Collaborator

grabbou commented Dec 12, 2024

I proposed an alternative approach in #108, in case we wanted to go with knowledge field. I will let you decide which approach should we go with.

@grabbou
Copy link
Collaborator

grabbou commented Dec 12, 2024

Going to close this one in favor of #108 as per discussion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants