feat: offer to store api key locally #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+86
to
+89
| if (save) { | ||
| execSync(`echo "OPENAI_API_KEY=${apiKey}" >> .env.local`) | ||
| execSync(`echo ".env.local" >> .gitignore`) | ||
| } |
There was a problem hiding this comment.
I wonder if saving to each project is a good idea, some tools introduce their own config file for example ai-cli created ~/.airc.json: https://github.com/callstack/ai-cli
I think most of the time user is going to use the same key between every project, wdyt?
There was a problem hiding this comment.
Yeah maybe let’s write to global config, that’s what I did in my project haha
There was a problem hiding this comment.
I did change this locally, but I am not sure what is the best way to save into global configuration, so I guess I am going to merge it for now "as is" and we can always re-iterate later!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Offers to save to local env file and adds it to gitignore
Asks the question if empty key is provided
Fixes #26