Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: flatlist not rendering in rntl repo #1467

Merged
merged 2 commits into from
Aug 22, 2023

Conversation

pierrezimmermannbam
Copy link
Collaborator

Summary

Fixes #1449

Because of the babel plugin for class properties (see this comment on the react native repo), rendering a flatlist would result in an error. Removing the plugin fixes the error, although I'm not sure why because that plugin is included in babel/preset-env for versions > 7 so we should have it no matter what. It may be an issue with different versions of the plugin, I haven't really understood what was the exact problem, I've tried to look at the transpiled files using the babel cli but they look exactly the same

Test plan

I added a test case for rendering a flatlist and all tests are passing

@codecov
Copy link

codecov bot commented Aug 21, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (4a8072d) 97.21% compared to head (9075365) 97.21%.

❗ Current head 9075365 differs from pull request most recent head e69dad4. Consider uploading reports for the commit e69dad4 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1467   +/-   ##
=======================================
  Coverage   97.21%   97.21%           
=======================================
  Files          76       76           
  Lines        4493     4493           
  Branches      647      647           
=======================================
  Hits         4368     4368           
  Misses        125      125           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@mdjastrzebski mdjastrzebski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @pierrezimmermannbam! 💯

@mdjastrzebski mdjastrzebski merged commit 4148038 into callstack:main Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: FlatList causing render errors in RNTL repo
2 participants