fix: flatlist not rendering in rntl repo #1467
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1449
Because of the babel plugin for class properties (see this comment on the react native repo), rendering a flatlist would result in an error. Removing the plugin fixes the error, although I'm not sure why because that plugin is included in babel/preset-env for versions > 7 so we should have it no matter what. It may be an issue with different versions of the plugin, I haven't really understood what was the exact problem, I've tried to look at the transpiled files using the babel cli but they look exactly the same
Test plan
I added a test case for rendering a flatlist and all tests are passing