feat: added onLongPress to RadioButton.Item and Checkbox.Item
#4215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @ondrejnedoma, thank you for your pull request 🤗. The documentation from this branch can be viewed here. |
kaushik1094
approved these changes
Dec 5, 2023
|
Hey @ondrejnedoma, please rename the commit message to follow the library convention |
|
Fixed the name, also took me a while to figure out how fork syncing works (or does not work) so sorry for the spam :D |
lukewalczak
changed the title
lukewalczak
changed the title
RadioButton.Item and Checkbox.Item
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
RadioButton.Item currently does not pass the "onLongPress" prop to the TouchableRipple component. This would be useful to implement to make RadioButton.Item elements be able to handle a secondary action.
Related issue
#4214
Test plan
Create a RadioButton.Item and pass it an onLongPress prop with a function that logs something into the console.