Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add Bluebirding Application to Showcase #4166

Merged
merged 1 commit into from
Nov 14, 2023

Conversation

crussell122
Copy link
Contributor

Adding the Bluebirding Application to the Showcase.

Looks like there's a few instances of showcase images that are being streched/squished due to the 9:16 aspect ratio of the showcase-image CSS class. Is there any reason why images are required to have a 9:16 aspect ratio?

@iM-GeeKy
Copy link

iM-GeeKy commented Nov 5, 2023

@lukewalczak I helped @crussell122 get this started, and it looks like there are some missing dependencies to get the docusaurus site up and running, hence the updated package.json and yarn.lock.

As for the aspect ratio issue I provided @crussell122 with a screenshot directly from the iOS simulator of our application. I had to fix this in react-native-paper-dates, the library I co-author, when I copied the showcase code you all have.

@callstack-bot
Copy link

callstack-bot commented Nov 5, 2023

Hey @crussell122, thank you for your pull request 🤗. The documentation from this branch can be viewed here.

@lukewalczak lukewalczak merged commit f4a18d3 into callstack:main Nov 14, 2023
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants