fix: adjust Text Input label width #4128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Hey @lukewalczak, thank you for your pull request 🤗. The documentation from this branch can be viewed here. |
lukewalczak
force-pushed
the
fix/adjust-label-max-width
branch
from
5d4ac50
to
9f7fc67
Compare
|
The mobile version of example app from this branch is ready! You can see it here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #4106
Summary
Correct the label container width to take windows width only on the mobile platform. Also adjusted label maxWidth to be reduced by padding to it doesn't stick to the border.
Related issue
Test plan
Updated snapshot.