Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: replace TouchableWithoutFeedback with Pressable #4117

Merged
merged 3 commits into from
Nov 28, 2023

Conversation

lukewalczak
Copy link
Member

@lukewalczak lukewalczak commented Oct 6, 2023

Summary

  • Replace the internally used TouchableWithoutFeedback in favor of Pressable component.

  • correct disabled prop in Chip

  • added disabled prop to DrawerItem and DrawerCollapsedItem

  • extended Chip example

Test plan

  • - test on three platforms
  • - updated snapshots

@lukewalczak lukewalczak marked this pull request as ready for review October 6, 2023 20:56
@lukewalczak lukewalczak changed the title refactor: replace TouchablesWithoutFeedback with Pressable refactor: replace TouchableWithoutFeedback with Pressable Oct 6, 2023
@github-actions
Copy link

github-actions bot commented Oct 6, 2023

The mobile version of example app from this branch is ready! You can see it here.

@callstack-bot
Copy link

callstack-bot commented Oct 8, 2023

Hey @lukewalczak, thank you for your pull request 🤗. The documentation from this branch can be viewed here.

@lukewalczak lukewalczak force-pushed the refactor/replace-touchables-with-pressable branch from 154d6ad to bb8a2ab Compare November 28, 2023 11:31
@lukewalczak lukewalczak added this to the 5.12.0 milestone Nov 28, 2023
@lukewalczak lukewalczak merged commit ac3820a into main Nov 28, 2023
3 checks passed
@lukewalczak lukewalczak deleted the refactor/replace-touchables-with-pressable branch November 28, 2023 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants