Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support for maxFontSizeMultiplier in text component #3823

Merged
merged 4 commits into from
Oct 16, 2023

Conversation

lukewalczak
Copy link
Member

@lukewalczak lukewalczak commented Apr 17, 2023

Summary

  • - add prop descriptions
  • - update snapshots
    - [x] - add default values

Test plan

@lukewalczak lukewalczak force-pushed the feat/max-font-size-multiplier branch from eabd869 to d9620ad Compare May 29, 2023 10:16
@lukewalczak lukewalczak marked this pull request as ready for review May 29, 2023 10:16
@callstack-bot
Copy link

callstack-bot commented May 29, 2023

Hey @lukewalczak, thank you for your pull request 🤗. The documentation from this branch can be viewed here.

@github-actions
Copy link

The mobile version of example app from this branch is ready! You can see it here.

@iM-GeeKy
Copy link

iM-GeeKy commented May 30, 2023

Summary

  • - add prop descriptions
  • - update snapshots
  • - add default values

Test plan

@lukewalczak There are two other components (Searchbar.tsx and Dialog.Title) that need this I believe. I've recorded them #3905 (comment).

@iM-GeeKy
Copy link

iM-GeeKy commented Aug 4, 2023

Is this planning to be released in 5.11.0?

@lukewalczak lukewalczak force-pushed the feat/max-font-size-multiplier branch from d9620ad to 05314c8 Compare August 6, 2023 13:35
@iM-GeeKy
Copy link

Summary

  • - add prop descriptions
  • - update snapshots
  • - add default values

Test plan

@lukewalczak There are two other components (Searchbar.tsx and Dialog.Title) that need this I believe. I've recorded them #3905 (comment).

@lukewalczak Is there any particular reason this isn't being finished?

@lukewalczak
Copy link
Member Author

Hello @iM-GeeKy,I intended to check another aspect concerning that feature, but unfortunately, I forgot about it, which has resulted in a delay in delivering those changes.

@iM-GeeKy
Copy link

Hello @iM-GeeKy,I intended to check another aspect concerning that feature, but unfortunately, I forgot about it, which has resulted in a delay in delivering those changes.

Sounds good, I've been using these changes with the two other components (Searchbar.tsx and Dialog.Title) via patch-package for a while and it has seemed to be working which is the only reason why I was interested in the delay, but thank you!

@github-actions
Copy link

github-actions bot commented Oct 2, 2023

The mobile version of example app from this branch is ready! You can see it here.

@lukewalczak
Copy link
Member Author

Edit: I've removed the initially added default value for maxFontSizeMultiplier prop.

@iM-GeeKy According to the both SearchBar and Dialog.Title components, looks like those are supporting maxFontSizeMultiplier due to spreading rest props into core components – respectively TextInput and Text.

@lukewalczak lukewalczak added this to the 5.11.0 milestone Oct 2, 2023
@jacquesdev
Copy link

I just came looking for support on the button component, and so happy that the support for it is so close now! Thanks everyone for working on this!

@lukewalczak lukewalczak added Typography and removed wip labels Oct 9, 2023
@lukewalczak lukewalczak merged commit a73ee15 into main Oct 16, 2023
3 checks passed
@lukewalczak lukewalczak deleted the feat/max-font-size-multiplier branch October 16, 2023 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants