-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support for maxFontSizeMultiplier in text component #3823
Conversation
eabd869
to
d9620ad
Compare
Hey @lukewalczak, thank you for your pull request 🤗. The documentation from this branch can be viewed here. |
The mobile version of example app from this branch is ready! You can see it here. |
@lukewalczak There are two other components ( |
Is this planning to be released in |
d9620ad
to
05314c8
Compare
@lukewalczak Is there any particular reason this isn't being finished? |
Hello @iM-GeeKy,I intended to check another aspect concerning that feature, but unfortunately, I forgot about it, which has resulted in a delay in delivering those changes. |
Sounds good, I've been using these changes with the two other components (Searchbar.tsx and Dialog.Title) via |
05314c8
to
adef226
Compare
The mobile version of example app from this branch is ready! You can see it here. |
Edit: I've removed the initially added default value for @iM-GeeKy According to the both |
I just came looking for support on the button component, and so happy that the support for it is so close now! Thanks everyone for working on this! |
64467d4
to
9197c9b
Compare
Summary
- [x] - add default valuesTest plan