Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add clean option for cleaning build directory #653

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

i-yusuf
Copy link

@i-yusuf i-yusuf commented Oct 18, 2024

Summary

Added a 'clean' flag to the build command with a default value of true.
This flag allows for optional cleaning of the build directory before executing the build process.
By default, the build directory will be cleaned unless explicitly set otherwise.

When using nodemon, the default behavior of deleting the output directory may cause issues with Metro Bundler. To avoid this, users can disable the clean flag by passing --clean false.

Test plan

  1. Run build (without any flags).
    • Ensure the build directory is cleaned by default.
  2. Run build --clean false.
    • Ensure the build proceeds without cleaning the build directory.
  3. Run build --clean.
    • Ensure the build directory is cleaned before building.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant