Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Allow bob.config.cjs #442

Merged
merged 1 commit into from
Sep 1, 2023

Conversation

samijaber
Copy link
Contributor

Summary

I have a library configured with "type": "module". This means that I need to provide bob.config.cjs, as .js extensions won't do. That config file needs to be explicitly added to the cosmicConfig

Copy link
Member

@satya164 satya164 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. Is it possible to add support for .mjs as well? I think it'd make sense if we're supporting .cjs extension.

@samijaber
Copy link
Contributor Author

@satya164 I did try to add .mjs as well but could not get it working out-of-the-box. Don't remember exactly what happened, but I got some type of error from CosmicConfig not knowing how to load .mjs extensions.

Could we still merge this and explore adding .mjs in a separate PR/branch?

@satya164
Copy link
Member

satya164 commented Sep 1, 2023

@samijaber sounds good

@satya164 satya164 enabled auto-merge (squash) September 1, 2023 13:11
@satya164 satya164 merged commit c139df5 into callstack:main Sep 1, 2023
@samijaber samijaber deleted the samijaber-patch-1 branch November 30, 2023 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants