People/davidgamba/rmd 23648 add reports to workflow #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
February 21, 2018 16:34
The workflow tasks can optionally fail if there are new flaws.
DavidGamba
changed the title
tonytvo
reviewed
Feb 22, 2018
| // Get the last build ID | ||
| build_id = VeracodeBuildList.getLatestBuildID(buildList) | ||
| log.info("Latest build_id: " + build_id) | ||
| newFlaws = printReportSummaryAndCheckForNewFlaws(veracodeAPI, outputDir, build_id) |
There was a problem hiding this comment.
sounds like this function is doing 2 things .... we could break this to printReportSummary
and later down, we could try to use isNewFlaws?
tonytvo
approved these changes
Feb 22, 2018
There was a problem hiding this comment.
other than breaking the printSummary function into smaller function, it looks good to me.
Although, the workflow function start to get big as it involves with too many business logic .... it seems like we might want to make it smaller and easier to test that function.....
DavidGamba
deleted the
people/davidgamba/rmd-23648-Add-reports-to-workflow
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@tonytvo please review.
When the Veracode Results are ready, running the workflow task will retrieve the last build's report.