Reimplement sharing system to address Safari issues #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Lodin tested all of the known edge cases and this looks good to me. Is it ready for merge/release? |
|
@calebdwilliams, yes, it is ready |
|
This fix is in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we have a lot of Safari-related bugs caused by the broken Safari CSSStyleSheet API (#84, #87), I decided to get back the original sharing system used in
2.x.xversions of the polyfill. It usestextContentproperty of theHTMLStyleSheetand storage for the additionalCSSStyleSheetmethods (insertRule, etc.) The system should solve any Safari issues because polyfill doesn't interact with the CSSStyleSheet API anymore.This PR returns that system. Along with the correct behavior, it also reduces the polyfill size to
1.82 kBaccording tosize-limit. Regarding the performance: I did some benchmarks, and it looks like the two versions have almost similar numbers. ThetextContentversion might be even slightly faster. So I don't expect any performance hit with this change.