This repository has been archived by the owner on Aug 16, 2023. It is now read-only.
fixes Foursquare versioning bug #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wow this is a weird way to do API versioning, but thanks for catching it! |
calebd
added a commit
that referenced
this pull request
Feb 13, 2014
Fixes Foursquare API version bug.
|
Thanks for merging. :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
From Foursquare documentation:
As of January 28, 2014, requests that do not include a v parameter will be rejected.I didn't see that one coming, so I updated the provider in order for it to work. :)
Also, any news on issue #17? Have you got any plan for the implementation of SSO providers? (Facebook, etc.)
Thanks,
Julien