Skip to content
This repository has been archived by the owner on Aug 16, 2023. It is now read-only.

Foursquare provider #20

Merged
merged 2 commits into from
Jan 23, 2014
Merged

Foursquare provider #20

merged 2 commits into from
Jan 23, 2014

Conversation

kornifex
Copy link
Contributor

The demo project was unable to find the correct header paths for the pods so I updated the project configuration to correct this.

@calebd
Copy link
Owner

calebd commented Jan 23, 2014

Sweet thanks! I'll check it out in a bit 😄

@calebd
Copy link
Owner

calebd commented Jan 23, 2014

Would you be ok if I changed the provider type from foursquare-web to just foursquare? The distinction is made for Facebook and Twitter since multiple providers for those types exist. I'm ok leaving the class names as they are, just wondering about the type since other developers will be typing that in to use it.

@kornifex
Copy link
Contributor Author

Hey,
At first I named it foursquare but as it is authenticating the user via the webview, it should be name -web, don't you think?
@amarcadet and I took a look at Foursquare's oauth sdk and we think that it should be possible to create a provider that authenticates the user with Foursquare's custom URL scheme. If we manage to do it, then we could name it foursquare and this one could remain as a fallback.
The library seems to try to launch Foursquare through their URL scheme and then fallbacks to StoreKit.
It could be a great provider for SimpleAuth!

We'll take a better look at it and might try to implement it. :)

@calebd
Copy link
Owner

calebd commented Jan 23, 2014

Yes that would be amazing! I didn't know they had SSO. I want to look into building providers like that for Dropbox and Facebook as well. Let me know if you need anything!

@calebd calebd merged commit 2fc99c0 into calebd:master Jan 23, 2014
@calebd
Copy link
Owner

calebd commented Jan 23, 2014

If you guys want to talk about the Foursquare SSO provider in particular, could we do it on #17? I think we'll need to add stuff to SimpleAuth/Core in order to support that.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants