Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix viewer.me avatar size #5392

Merged
merged 2 commits into from
Nov 5, 2022
Merged

Fix viewer.me avatar size #5392

merged 2 commits into from
Nov 5, 2022

Conversation

hariombalhara
Copy link
Member

What does this PR do?

Fixes #5299 (comment)

Environment: Production

Type of change

  • Improvement (non-breaking change which fixes an issue)

@vercel
Copy link

vercel bot commented Nov 5, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
cal ❌ Failed (Inspect) Nov 5, 2022 at 5:37PM (UTC)

@what-the-diff
Copy link

what-the-diff bot commented Nov 5, 2022

  • The avatar field in the viewer object is changed from a string to an expression.
  • The value of the avatar field is now ${CAL_URL}/${user.username}/avatar.png instead of just user's username (e.g., "johndoe").

Copy link
Contributor

@emrysal emrysal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good spot!

@emrysal
Copy link
Contributor

emrysal commented Nov 5, 2022

Added SSRConfig to the NextJsAppProps typing to workaround a broken type in next-i18next - will be fixed v13.0.0 but until then.. keeping an eye on i18next/next-i18next#1944

@emrysal emrysal merged commit a8c4a9c into main Nov 5, 2022
@emrysal emrysal deleted the fix/viewer.me/avatar branch November 5, 2022 18:00
emrysal added a commit that referenced this pull request Nov 10, 2022
* Fix viewer.me avatar size

* Fix for i18n-next typecheck

Co-authored-by: Alex van Andel <[email protected]>
haffla pushed a commit to tourlane/cal.com that referenced this pull request Nov 22, 2022
* Fix viewer.me avatar size

* Fix for i18n-next typecheck

Co-authored-by: Alex van Andel <[email protected]>
@PeerRich PeerRich added the core area: core, team members only label Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core area: core, team members only
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants