-
Notifications
You must be signed in to change notification settings - Fork 7.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Round Robin Skip If contact owner first available slot is more than 2 weeks, round robin as normal #17416
base: main
Are you sure you want to change the base?
Conversation
Hey there and thank you for opening this pull request! 👋🏼 We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted. Details:
|
Graphite Automations"Add consumer team as reviewer" took an action on this PR • (10/31/24)1 reviewer was added to this PR based on Keith Williams's automation. |
hosts: eventHosts, | ||
routedTeamMemberIds: input.routedTeamMemberIds ?? null, | ||
contactOwnerEmail, | ||
}); | ||
|
||
if ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We move all this logic into a separate function. Since we need to calculate the availability of the contact owner. If the first slot is more than 2 weeks away we then need to calculate the availability of the other members.
const getStartTime = ( | ||
startTimeInput: string, | ||
timeZone?: string, | ||
eventType: Exclude<Awaited<ReturnType<typeof getRegularOrDynamicEventType>>, null> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we be more specific in the typing here? just specify minimumBookingNotice as part of the event type.
What does this PR do?
In a sales environment, we want prospects to book a time that is not too far out. If the contact owner does not have an open slot within two weeks, default to normal round robin (includes attribute routing)
https://www.loom.com/share/251967b87fab4b028f3af7637ce3d270?from_recorder=1&focus_title=1
Mandatory Tasks (DO NOT REMOVE)
How should this be tested?
Checklist