fix: Users details leak for team booking when the team is private #17403
+28
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@anikdhabal is attempting to deploy a commit to the cal Team on Vercel. A member of the Team first needs to authorize it. |
dosubot
bot
added
teams
anikdhabal
added
High priority
Graphite Automations"Add consumer team as reviewer" took an action on this PR • (10/30/24)1 reviewer was added to this PR based on Keith Williams's automation. "Add community label" took an action on this PR • (10/30/24)1 label was added to this PR based on Keith Williams's automation. |
anikdhabal
changed the title
Udit-takkar
reviewed
Oct 30, 2024
Udit-takkar
reviewed
Oct 30, 2024
| @@ -19,7 +19,7 @@ export type useScheduleForEventReturnType = ReturnType<typeof useScheduleForEven | |||
| * Using this hook means you only need to use one hook, instead | |||
| * of combining multiple conditional hooks. | |||
| */ | |||
| export const useEvent = (props?: { fromRedirectOfNonOrgLink?: boolean }) => { | |||
| export const useEvent = (props?: { fromRedirectOfNonOrgLink?: boolean; currentUserId?: number }) => { | |||
There was a problem hiding this comment.
This would make useEvent dependent on useSession and we should get the logged in user id on the server
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Bug:-
Currently the team is Private, but
Mandatory Tasks (DO NOT REMOVE)
How should this be tested?
Checklist