Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Not able to create consecutive ooo #17388

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: Not able to create consecutive ooo #17388

wants to merge 1 commit into from

Conversation

vijayraghav-io
Copy link
Contributor

What does this PR do?

Issue:
https://www.loom.com/share/3bb5b7022156496b8ab936bb5e161cbf?sid=a5392921-b3a6-4e47-80f2-4951e80aa811

Fix:
https://www.loom.com/share/aaa9fd01fcb440738ffa6e144e4bb59e?sid=87f987e5-0e29-4719-9845-0f125a9c5c2c

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

@vercel Vercel
Copy link

vercel bot commented Oct 29, 2024

@vijayraghav-io is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions bot added the 🐛 bug Something isn't working label Oct 29, 2024
@graphite-app graphite-app bot requested a review from a team October 29, 2024 11:21
@graphite-app graphite-app bot added the community Created by Linear-GitHub Sync label Oct 29, 2024
@graphite-app Graphite App
Copy link

graphite-app bot commented Oct 29, 2024 •
edited
Loading

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (10/29/24)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add community label" took an action on this PR • (10/29/24)

1 label was added to this PR based on Keith Williams's automation.

"Add ready-for-e2e label" took an action on this PR • (10/30/24)

1 label was added to this PR based on Keith Williams's automation.

AliPythonDev
AliPythonDev reviewed Oct 30, 2024
View reviewed changes
packages/trpc/server/routers/loggedInViewer/outOfOffice.handler.ts
Comment on lines +35 to +36
const startDateUtc = dayjs.utc(startDate).add(input.offset, "minute");
const endDateUtc = dayjs.utc(endDate).add(input.offset, "minute");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good use of startDateUtc and endDateUtc for consistent date handling. Should help avoid time zone issues

AliPythonDev
AliPythonDev approved these changes Oct 30, 2024
View reviewed changes
Copy link
Contributor

@AliPythonDev AliPythonDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall!
Just a couple of small tweaks noted, nice work on improving the OOO checks.

@github-actions GitHub Actions
Copy link
Contributor

E2E results are ready!

@keithwillcode
Copy link
Contributor

Looks good overall! Just a couple of small tweaks noted, nice work on improving the OOO checks.

@AliPythonDev Has this been tested to ensure it works? I see no automated tests were modified in this PR (which should happen)

@vijayraghav-io
Copy link
Contributor Author

Looks good overall! Just a couple of small tweaks noted, nice work on improving the OOO checks.

@AliPythonDev Has this been tested to ensure it works? I see no automated tests were modified in this PR (which should happen)

yes sure will add/update tests.

keithwillcode
keithwillcode requested changes Oct 31, 2024
View reviewed changes
Copy link
Contributor

@keithwillcode keithwillcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Marking as requested changes while @vijayraghav-io updates the tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keithwillcode keithwillcode keithwillcode requested changes

@AliPythonDev AliPythonDev AliPythonDev approved these changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
🐛 bug Something isn't working community Created by Linear-GitHub Sync ready-for-e2e
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Not able to create consecutive OOO
3 participants
@vijayraghav-io @keithwillcode @AliPythonDev