Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: settings/platform, settings/license-key - remove pages router and use app router #17384

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

chore: settings/platform, settings/license-key - remove pages router and use app router #17384

wants to merge 6 commits into from

Conversation

hbjORbj
Copy link
Contributor

@hbjORbj hbjORbj commented Oct 29, 2024 •
edited
Loading

What does this PR do?

  • Fixes CAL-4402
  • Fixes CAL-4406
  • remove pages router and use app router for all pages in settings/platform
  • remove settings/license-key/new
  • remove env vars not needed anymore as a result

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • N/A - I have added a Docs issue here if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

Test a total of 7 pages:

  1. settings/platform/index.tsx
  2. settings/platform/new/index.tsx
  3. settings/platform/oauth-clients/[clientId]/edit/index.tsx
  4. settings/platform/oauth-clients/[clientId]/edit/webhooks.tsx
  5. settings/platform/oauth-clients/create.tsx
  6. settings/platform/billing
  7. settings/platform/plans
  8. settings/license-key/new

@vercel Vercel
Copy link

vercel bot commented Oct 29, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Visit Preview Oct 29, 2024 4:09pm
calcom-web-canary ⬜️ Ignored (Inspect) Visit Preview Oct 29, 2024 4:09pm

@github-actions github-actions bot added the ❗️ .env changes contains changes to env variables label Oct 29, 2024
@keithwillcode keithwillcode added consumer core area: core, team members only labels Oct 29, 2024
@dosubot dosubot bot added the platform Anything related to our platform plan label Oct 29, 2024
@graphite-app graphite-app bot requested review from a team October 29, 2024 07:35
@linear Linear
Copy link

linear bot commented Oct 29, 2024

CAL-4402 `settings/platform` - Use app router and remove pages router

CAL-4406 `settings/license-key` - Use app router and remove pages router

hbjORbj
hbjORbj commented Oct 29, 2024
View reviewed changes
.env.example
@@ -335,8 +335,6 @@ AB_TEST_BUCKET_PROBABILITY=50
APP_ROUTER_EVENT_TYPES_ENABLED=0
APP_ROUTER_SETTINGS_DEVELOPER_ENABLED=0
APP_ROUTER_SETTINGS_ADMIN_ENABLED=0
APP_ROUTER_SETTINGS_MY_ACCOUNT_ENABLED=0
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you wonder where APP_ROUTER_SETTINGS_LICENSE_KEY_ENABLED is, we do not have it :P

@graphite-app graphite-app bot requested a review from a team October 29, 2024 07:38
@graphite-app Graphite App
Copy link

graphite-app bot commented Oct 29, 2024

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (10/29/24)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add foundation team as reviewer" took an action on this PR • (10/29/24)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add platform team as reviewer" took an action on this PR • (10/29/24)

1 reviewer was added to this PR based on Keith Williams's automation.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 29, 2024 •
edited
Loading

E2E results are ready!

@hbjORbj hbjORbj marked this pull request as draft October 29, 2024 08:07
@hbjORbj hbjORbj marked this pull request as ready for review October 30, 2024 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
consumer core area: core, team members only ❗️ .env changes contains changes to env variables platform Anything related to our platform plan ready-for-e2e
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hbjORbj @keithwillcode