feat: past and overlapping ooo #17373
Open
+6
−53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Amit91848 is attempting to deploy a commit to the cal Team on Vercel. A member of the Team first needs to authorize it. |
github-actions
bot
added
💎 Bounty
Graphite Automations"Add consumer team as reviewer" took an action on this PR • (10/28/24)1 reviewer was added to this PR based on Keith Williams's automation. "Add community label" took an action on this PR • (10/28/24)1 label was added to this PR based on Keith Williams's automation. |
emrysal
reviewed
Oct 30, 2024
|
|
||
| function Calendar({ | ||
| className, | ||
| classNames, | ||
| fromDate, | ||
| toDate, | ||
| showOutsideDays = true, | ||
| disablePastDates = true, |
There was a problem hiding this comment.
would prefer this to be a minDate option (set by default to new Date()) - and nullable to allow all dates enabled.
Edit: This can be implemented to a minor tweak to the fromDate instead of introducing a new param.
Amit91848
commented
Oct 31, 2024
| @@ -21,7 +21,7 @@ function Calendar({ | |||
| }: CalendarProps) { | |||
| return ( | |||
| <DayPicker | |||
| fromDate={fromDate || new Date()} | |||
| fromDate={fromDate} | |||
There was a problem hiding this comment.
Handled in parent component
| @@ -63,7 +64,8 @@ export function DatePickerWithRange({ | |||
| sideOffset={4}> | |||
| <Calendar | |||
| initialFocus | |||
| fromDate={minDate} | |||
| //When explicitly null, we want past dates to be shown as well, otherwise show only dates passed or from current date | |||
There was a problem hiding this comment.
Added comment because this is confusing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Screencast.from.2024-10-28.21-26-38.webm
Mandatory Tasks (DO NOT REMOVE)