feat: Refactor to Use credentialRepository for credential create.

[vijayraghav-io]

What does this PR do?

• Fixes Refactor to use CredentialRepository for credential create #17337
• Fixes CAL-XXXX (Linear issue number - should be visible at the bottom of the GitHub issue description)

Refer PR: #16878

To Do :
Remove explicit callings of BookingReferenceRepository.reconnectWithNewCredential() everywhere, introduced from the PR #16878, if that Issue fix PR is merged before.

Mandatory Tasks (DO NOT REMOVE)

• I have self-reviewed the code (A decent size PR without self-review might be rejected).
• I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
• I confirm automated tests are in place that prove my fix is effective or that my feature works.

[vercel]

@vijayraghav-io is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

[graphite-app]

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (10/25/24)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add foundation team as reviewer" took an action on this PR • (10/25/24)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add community label" took an action on this PR • (10/25/24)

1 label was added to this PR based on Keith Williams's automation.

"Add ready-for-e2e label" took an action on this PR • (10/28/24)

1 label was added to this PR based on Keith Williams's automation.

[AliPythonDev]

The Prisma.JsonNull handling for key is also a solid choice for cleaner code. Nicely done!

[Praashh]

I did notice, In the second test case you are using the newGoogleCalCredentialId, This might be involuntary as google_meet_video should ideally connect to the newGoogleMeetCredentialId instead of newGoogleCalCredentialId.

[vijayraghav-io]

I did notice, In the second test case you are using the newGoogleCalCredentialId, This might be involuntary as google_meet_video should ideally connect to the newGoogleMeetCredentialId instead of newGoogleCalCredentialId.

Good notice!. This is intentional, google_video being a special case and that's why this test case was added.
Please refer this

cal.com/packages/features/bookings/lib/handleNewBooking.ts

Line 1130 in 7d51741

credentialId: updateManager.referencesToCreate[googleCalIndex].credentialId,

here the credential of googleCal is mapped to google_meet_video as well, while creating the bookingReferences for new booking.
As per the generic app installation flow, credential record for google_video will be created, but the keys will be empty, google_calendar 's credential is only used for google video as well.

[Praashh]

I did notice, In the second test case you are using the newGoogleCalCredentialId, This might be involuntary as google_meet_video should ideally connect to the newGoogleMeetCredentialId instead of newGoogleCalCredentialId.

Good notice!. This is intentional, google_video being a special case and that's why this test case was added. Please refer this

cal.com/packages/features/bookings/lib/handleNewBooking.ts

Line 1130 in 7d51741

credentialId: updateManager.referencesToCreate[googleCalIndex].credentialId,

here the credential of googleCal is mapped to google_meet_video as well, while creating the bookingReferences for new booking. As per the generic app installation flow, credential record for google_video will be created, but the keys will be empty, google_calendar 's credential is only used for google video as well.

ahh got it, I need a final check, I'll let you know..

[Praashh]

tested the changes locally, looks good to me.

[github-actions]

E2E results are ready!

• Workflow #36254.1 latest results

[keithwillcode]

Just blocking this from merge until @joeauyeung can take a look