feat: google meet no show #17271

Udit-takkar · 2024-10-23T12:16:23Z

What does this PR do?

Fixes [CAL-4501] track no shows with google meet #17061 (GitHub issue number)
Fixes CAL-4501 (Linear issue number - should be visible at the bottom of the GitHub issue description)

Mandatory Tasks (DO NOT REMOVE)

I have self-reviewed the code (A decent size PR without self-review might be rejected).
N/A I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
N/A I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

Connect google calendar and install google meet
Create a event type and add webhook events after hosts don't join google meet, after guests don't join google meet.
Book a meeting and check Task Table

If you also want to test triggerHostNoShow then in L63 packages/features/bookings/lib/handleNewBooking/scheduleNoShowTriggers.ts add this code


import { triggerHostNoShow } from "@calcom/features/tasker/tasks/triggerNoShow/triggerHostNoShow";

await triggerHostNoShow(
      JSON.stringify({
        triggerEvent: WebhookTriggerEvents.AFTER_HOSTS_GOOGLE_MEET_NO_SHOW,
        bookingId: booking.id,
        webhook: {
          ...subscribersHostsNoShowStarted[0],
          time: subscribersHostsNoShowStarted[0].time,
          timeUnit: subscribersHostsNoShowStarted[0].timeUnit,
        },
        destinationCalendar,
      })
    );

vercel · 2024-10-23T12:16:29Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments

Name	Status	Preview	Comments	Updated (UTC)
cal	⬜️ Ignored (Inspect)	Visit Preview		Oct 24, 2024 1:19pm
calcom-web-canary	⬜️ Ignored (Inspect)	Visit Preview		Oct 24, 2024 1:19pm

github-actions · 2024-10-23T12:16:37Z

Hey there and thank you for opening this pull request! 👋🏼

We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted.

Details:

linear · 2024-10-23T13:24:09Z

CAL-4501 track no shows with google meet

socket-security · 2024-10-24T13:14:02Z

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package	New capabilities	Transitives	Size	Publisher
npm/[email protected]	None	`0`	221 kB	dcode

View full report↗︎

Udit-takkar · 2024-10-24T13:24:48Z

packages/app-store/googlecalendar/lib/constants.ts

+export const SCOPE_USERINFO_EMAIL = "https://www.googleapis.com/auth/userinfo.email";

-export const REQUIRED_SCOPES = [SCOPE_CALENDAR_READONLY, SCOPE_CALENDAR_EVENT];
+export const SCOPE_USER_CONTACTS = "https://www.googleapis.com/auth/contacts.readonly";
+export const SCOPE_OTHER_USER_CONTACTS = "https://www.googleapis.com/auth/contacts.other.readonly";


Need these scope to fetch user's workspace accounts email.

Udit-takkar · 2024-10-24T13:25:14Z

packages/app-store/googlecalendar/lib/constants.ts

@@ -1,7 +1,18 @@
 export const SCOPE_USERINFO_PROFILE = "https://www.googleapis.com/auth/userinfo.profile";
 export const SCOPE_CALENDAR_READONLY = "https://www.googleapis.com/auth/calendar.readonly";
 export const SCOPE_CALENDAR_EVENT = "https://www.googleapis.com/auth/calendar.events";
+export const GOOGLE_MEET_API = "https://www.googleapis.com/auth/meetings.space.readonly";


Need this scope to fetch details about meeting and fetch participants

Udit-takkar · 2024-10-24T13:26:44Z

packages/features/bookings/lib/handleNewBooking/scheduleNoShowTriggers.ts

+  // TODO: is this correct?
+  const destinationCalendar = destinationCalendars?.find((cal) => cal.userId === organizerUser.id);
+


we need the destination calendar of the organizer (that created the google meet url).

Udit-takkar · 2024-10-24T13:27:45Z

packages/features/tasker/tasks/triggerNoShow/common.ts

+  if (
+    !!dailyVideoReference &&
+    (booking.location === DailyLocationType || booking.location?.trim() === "" || !booking.location)
+  ) {
+    const meetingDetails = await getMeetingSessionsFromRoomName(dailyVideoReference.uid);
+
+    const allParticipants = meetingDetails.data.flatMap((meeting) => meeting.participants);
+
+    const hostsThatDidntJoinTheCall = hosts.filter(
+      (host) => !checkIfUserJoinedTheCall(host.id, allParticipants)
+    );
+
+    const numberOfHostsThatJoined = hosts.length - hostsThatDidntJoinTheCall.length;
+
+    const didGuestJoinTheCall = meetingDetails.data.some(
+      (meeting) => meeting.max_participants < numberOfHostsThatJoined
+    );
+
+    return {
+      hostsThatDidntJoinTheCall,
+      booking,
+      numberOfHostsThatJoined,
+      webhook,
+      didGuestJoinTheCall,
+      triggerEvent,
+    };


this is same as before

Udit-takkar · 2024-10-24T13:29:20Z

packages/app-store/googlecalendar/lib/CalendarService.ts

+    const googleAuth = new GoogleAuth({
+      authClient: new OAuth2Client({
+        credentials: {
+          access_token: token.access_token,
+        },
+      }),
+    });
+


It was throwing type error when i used the Google auth client in this class so i had to create this one

Udit-takkar · 2024-10-24T13:30:56Z

packages/app-store/googlecalendar/lib/CalendarService.ts

+    const spaceName = spaceInfo[0].name;
+
+    const conferenceRecords = [];
+    for await (const response of meetClient.listConferenceRecordsAsync()) {


meetClient.listConferenceRecordsAsync() returns all conference records which were created by the user. conference record refers to a meeting.

Udit-takkar · 2024-10-24T13:31:17Z

packages/app-store/googlecalendar/lib/CalendarService.ts

+    const conferenceRecords = [];
+    for await (const response of meetClient.listConferenceRecordsAsync()) {
+      if (response.space === spaceName) {
+        conferenceRecords.push(response);


we only want the conference record on our meeting url

Udit-takkar · 2024-10-24T13:31:43Z

packages/app-store/googlecalendar/lib/CalendarService.ts

+              const response = await fetch(
+                `https://people.googleapis.com/v1/people/${
+                  participant.signedinUser?.user?.split("/")[1]
+                }?personFields=emailAddresses`,


fetch email here by id

graphite-app · 2024-10-24T13:40:11Z

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (10/24/24)

1 reviewer was added to this PR based on Keith Williams's automation.

keithwillcode · 2024-10-24T16:03:22Z

apps/web/modules/settings/platform/oauth-clients/[clientId]/edit/edit-webhooks-view.tsx

@@ -77,6 +77,14 @@ export default function EditOAuthClientWebhooks() {
                    value: WebhookTriggerEvents.AFTER_GUESTS_CAL_VIDEO_NO_SHOW,
                    label: "after_guests_cal_video_no_show",
                  },
+                  {


Should these be separate per video type? Seems like it should be AFTER_HOSTS_NO_SHOW and AFTER_GUESTS_NO_SHOW no matter which video type they used.

keithwillcode · 2024-10-24T16:04:30Z

packages/features/bookings/lib/handleNewBooking/scheduleNoShowTriggers.ts

  const noShowPromises: Promise<any>[] = [];

-  const subscribersHostsNoShowStarted = await getWebhooks({
+  const hostNoShowTriggerEvent = isDailyVideoLocation


My previous comment applies here. This list will continue to grow larger and larger for the more video integrations we detect no shows for. Do we absolutely have to do this?

Udit-takkar added 2 commits October 23, 2024 17:45

feat: google meet automatic no show

1df2bbe

chore: add Calendar service

744a04c

github-actions bot added the ❗️ migrations contains migration files label Oct 23, 2024

keithwillcode added core area: core, team members only enterprise area: enterprise, audit log, organisation, SAML, SSO labels Oct 23, 2024

Merge branch 'main' into feat/google-meet-no-show

9254ca3

Udit-takkar changed the title ~~Feat/google meet no show~~ feat: google meet no show Oct 23, 2024

vercel bot had a problem deploying to Preview – api October 23, 2024 12:26 Failure

vercel bot deployed to Preview – dev October 23, 2024 12:51 View deployment

feat: send no show events

9e2890b

vercel bot had a problem deploying to Preview – api October 23, 2024 13:19 Failure

refactor: simplify code

47017b6

vercel bot had a problem deploying to Preview – api October 23, 2024 13:27 Failure

vercel bot deployed to Preview – dev October 23, 2024 13:48 View deployment

fix: type error

223cf4d

github-actions bot added calendar-apps area: calendar, google calendar, outlook, lark, microsoft 365, apple calendar consumer High priority Created by Linear-GitHub Sync ✨ feature New feature or request labels Oct 23, 2024

vercel bot had a problem deploying to Preview – api October 23, 2024 19:34 Failure

vercel bot deployed to Preview – dev October 23, 2024 19:46 View deployment

Udit-takkar added 2 commits October 24, 2024 01:48

fix: more type error

c7ac4a9

chore: few more

99c670b

vercel bot had a problem deploying to Preview – api October 23, 2024 20:25 Failure

vercel bot deployed to Preview – dev October 23, 2024 20:37 View deployment

Merge branch 'main' into feat/google-meet-no-show

a1c4fc7

vercel bot had a problem deploying to Preview – api October 24, 2024 12:40 Failure

fix: test and type error

e1f95a5

vercel bot had a problem deploying to Preview – api October 24, 2024 12:55 Failure

vercel bot deployed to Preview – dev October 24, 2024 13:10 View deployment

fix: type error

92f12f0

vercel bot deployed to Preview – api October 24, 2024 13:20 View deployment

Udit-takkar commented Oct 24, 2024

View reviewed changes

Udit-takkar marked this pull request as ready for review October 24, 2024 13:35

dosubot bot added the app-store area: app store, apps, calendar integrations, google calendar, outlook, lark, apple calendar label Oct 24, 2024

dosubot bot added this to the v4.7 milestone Oct 24, 2024

vercel bot deployed to Preview – dev October 24, 2024 13:36 View deployment

graphite-app bot requested a review from a team October 24, 2024 13:36

zomars added the ready-for-e2e label Oct 24, 2024

keithwillcode requested changes Oct 24, 2024

View reviewed changes

Udit-takkar marked this pull request as draft October 25, 2024 07:33

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: google meet no show #17271

feat: google meet no show #17271

Udit-takkar commented Oct 23, 2024 •

edited

Loading

vercel bot commented Oct 23, 2024 •

edited

Loading

github-actions bot commented Oct 23, 2024 •

edited by Udit-takkar

Loading

linear bot commented Oct 23, 2024

socket-security bot commented Oct 24, 2024

Udit-takkar Oct 24, 2024

Udit-takkar Oct 24, 2024

Udit-takkar Oct 24, 2024

Udit-takkar Oct 24, 2024

Udit-takkar Oct 24, 2024

Udit-takkar Oct 24, 2024

Udit-takkar Oct 24, 2024

Udit-takkar Oct 24, 2024

graphite-app bot commented Oct 24, 2024

keithwillcode Oct 24, 2024

keithwillcode Oct 24, 2024

		// TODO: is this correct?
		const destinationCalendar = destinationCalendars?.find((cal) => cal.userId === organizerUser.id);

feat: google meet no show #17271

Are you sure you want to change the base?

feat: google meet no show #17271

Conversation

Udit-takkar commented Oct 23, 2024 • edited Loading

What does this PR do?

Mandatory Tasks (DO NOT REMOVE)

How should this be tested?

vercel bot commented Oct 23, 2024 • edited Loading

github-actions bot commented Oct 23, 2024 • edited by Udit-takkar Loading

linear bot commented Oct 23, 2024

socket-security bot commented Oct 24, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

graphite-app bot commented Oct 24, 2024

Graphite Automations

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Udit-takkar commented Oct 23, 2024 •

edited

Loading

vercel bot commented Oct 23, 2024 •

edited

Loading

github-actions bot commented Oct 23, 2024 •

edited by Udit-takkar

Loading