Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: "Sign in with Google" should integrate Google Calendar #17251

Draft
wants to merge 18 commits into
base: main
Choose a base branch
from
Draft

feat: "Sign in with Google" should integrate Google Calendar #17251

wants to merge 18 commits into from
+111 −10

Conversation

hbjORbj
Copy link
Contributor

@hbjORbj hbjORbj commented Oct 22, 2024

What does this PR do?

  • Fixes #XXXX (GitHub issue number)
  • Fixes CAL-XXXX (Linear issue number - should be visible at the bottom of the GitHub issue description)

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

  • Are there environment variables that should be set?
  • What are the minimal test data to have?
  • What is expected (happy path) to have (input and output)?
  • Any other important info that could help to test that PR

Checklist

  • I haven't read the contributing guide
  • My code doesn't follow the style guidelines of this project
  • I haven't commented my code, particularly in hard-to-understand areas
  • I haven't checked if my changes generate no new warnings

@hbjORbj hbjORbj marked this pull request as draft October 22, 2024 15:55
@keithwillcode keithwillcode added consumer core area: core, team members only labels Oct 22, 2024
@dosubot dosubot bot added authentication area: authentication, auth, google sign in, password, SAML, password reset, can't log in calendar-apps area: calendar, google calendar, outlook, lark, microsoft 365, apple calendar ✨ feature New feature or request labels Oct 22, 2024
@graphite-app graphite-app bot requested a review from a team October 22, 2024 15:55
@graphite-app Graphite App
Copy link

graphite-app bot commented Oct 22, 2024

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (10/22/24)

1 reviewer was added to this PR based on Keith Williams's automation.

@vercel Vercel
Copy link

vercel bot commented Oct 23, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Visit Preview Oct 23, 2024 2:51pm
calcom-web-canary ⬜️ Ignored (Inspect) Visit Preview Oct 23, 2024 2:51pm

@github-actions github-actions bot added the ❗️ .env changes contains changes to env variables label Oct 23, 2024
sean-brydon
sean-brydon reviewed Oct 25, 2024
View reviewed changes
packages/features/auth/lib/next-auth-options.ts
@@ -607,6 +622,62 @@ export const getOptions = ({
return await autoMergeIdentities();
}

if (account.provider === "google") {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great so far! I wonder if we should extract some of this logic to a helper somewhere!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sean-brydon sean-brydon sean-brydon left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
authentication area: authentication, auth, google sign in, password, SAML, password reset, can't log in calendar-apps area: calendar, google calendar, outlook, lark, microsoft 365, apple calendar consumer core area: core, team members only ❗️ .env changes contains changes to env variables ✨ feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hbjORbj @sean-brydon @keithwillcode