Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: payment card atom #17203

Merged
merged 23 commits into from
Oct 31, 2024
Merged

feat: payment card atom #17203

merged 23 commits into from
Oct 31, 2024

Conversation

Ryukemeister
Copy link
Contributor

@Ryukemeister Ryukemeister commented Oct 20, 2024 •
edited
Loading

What does this PR do?

  • Adds payment form that can be used for accepting paid bookings via stripe

For an individual user -

Screen.Recording.2024-10-30.at.7.42.12.PM.mov

For a team -

Screen.Recording.2024-10-30.at.7.46.33.PM.mov

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

  1. start webapp

  2. run this command for stripe webhooks
    stripe listen --forward-to http://localhost:3000/api/integrations/stripepayment/webhook

  3. run v2

  4. build atoms

  5. start examples app and then try to set some payment for one of your event types

@keithwillcode keithwillcode added core area: core, team members only platform Anything related to our platform plan labels Oct 20, 2024
@vercel Vercel
Copy link

vercel bot commented Oct 20, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Visit Preview Oct 31, 2024 8:26am
calcom-web-canary ⬜️ Ignored (Inspect) Visit Preview Oct 31, 2024 8:26am

@Ryukemeister Ryukemeister mentioned this pull request Oct 28, 2024
Open
3 tasks
@ThyMinimalDev ThyMinimalDev marked this pull request as ready for review October 30, 2024 12:57
@dosubot dosubot bot added the ✨ feature New feature or request label Oct 30, 2024
@graphite-app graphite-app bot requested a review from a team October 30, 2024 12:59
@graphite-app Graphite App
Copy link

graphite-app bot commented Oct 30, 2024

Graphite Automations

"Add platform team as reviewer" took an action on this PR • (10/30/24)

1 reviewer was added to this PR based on Keith Williams's automation.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 30, 2024 •
edited
Loading

E2E results are ready!

@ThyMinimalDev ThyMinimalDev enabled auto-merge (squash) October 31, 2024 08:37
@ThyMinimalDev
Copy link
Contributor

amazing work tested in dev it works as expected

@ThyMinimalDev ThyMinimalDev merged commit fee3b73 into main Oct 31, 2024
38 checks passed
@ThyMinimalDev ThyMinimalDev deleted the stripe-payment-form branch October 31, 2024 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ThyMinimalDev ThyMinimalDev ThyMinimalDev approved these changes

Assignees
No one assigned
Labels
core area: core, team members only ✨ feature New feature or request platform Anything related to our platform plan ready-for-e2e
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Ryukemeister @ThyMinimalDev @keithwillcode