Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Updated Huddle01 App Flow #16907

Merged
merged 49 commits into from
Oct 22, 2024
Merged

feat: Updated Huddle01 App Flow #16907

merged 49 commits into from
Oct 22, 2024

Conversation

ponikar
Copy link
Contributor

@ponikar ponikar commented Oct 2, 2024

What does this PR do?

  • We at Huddle01 have revamped several things, including how users interact and communicate through the Huddle01 app. Huddle01 now has a dedicated OAuth mechanism that empowers third-party applications like CalCom. To make CalCom compatible with the new flow, we have rewritten the current app.
  • Introduced an Authentication page to allow users to confirm their identity before scheduling a call.
  • Added Huddle01 OAuth support that works independently.
  • Introduced a new set of APIs to communicate with Huddle01 servers.

https://www.loom.com/share/d3d725a07fc54ae0b7cb95a608b183d2?sid=b5c0a6fd-3766-45e8-83d4-c38134e3088f.

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • I have added a Docs issue here if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

  • Once you install a fresh Huddle01 app, you are required to confirm your identity via login to the Huddle01 auth page.

  • Once the authentication process succeeds, you can configure your events to use the Huddle01 app to schedule meetings when users make bookings.

  • Now, while booking a call, the user should see the Huddle01 app to book the call.

  • API calls should work, and the user should see the meeting link after the booking is made.

  • Test modify and cancel flows; we have added separate API calls corresponding to each functionality.

  • On the booking pages, meeting details should be visible.

  • Are there environment variables that should be set?

    • Yes, we have a new HUDDLE01_API_TOKEN to handle the authentication process. It needs to be set.
  • What are the minimal test data requirements?

    • Huddle01 account to test authentication.
  • What is expected (happy path) to have (input and output)?

    • Install the Huddle01 app and complete the authentication process.
    • Configure your events to use the Huddle01 app for scheduling meetings.
    • Users should be able to schedule, modify, and cancel the meeting.

Checklist

  • I haven't read the contributing guide
  • My code doesn't follow the style guidelines of this project.
  • I haven't commented my code, particularly in hard-to-understand areas.
  • I haven't checked if my changes generate no new warnings.

@ponikar
Copy link
Contributor Author

ponikar commented Oct 15, 2024

@anikdhabal Hey any updates on this?

@anikdhabal
Copy link
Contributor

@ponikar Thanks for your work. But I have a suggestion for users who have already installed it

I think we can keep the same app and implement oauth for new install. But just making sure that legacy ones still works. And if someone wants to use the new one they can just uninstall and reinstall. We could also provide some banner for people with the legacy version

@ponikar
Copy link
Contributor Author

ponikar commented Oct 17, 2024

Thanks for the response. I will talk with my team and will get back to you by end of the day.

@ponikar
Copy link
Contributor Author

ponikar commented Oct 18, 2024

Hey @anikdhabal

Thanks for the response, We are good with the flow you suggested, We will support backward compatibly for old users.

We could also provide some banner for people with the legacy version
Please share more details on this, we would want to encourage old users to update the app.

Also, If everything is good, can you please tell me where this PR will get merge and deploy?

@ponikar
Copy link
Contributor Author

ponikar commented Oct 21, 2024

Hey @anikdhabal please let me know if we are good with merging this PR, let me know if I have to make any changes.
Thanks

Copy link
Contributor

@anikdhabal anikdhabal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great Work @ponikar

@anikdhabal anikdhabal enabled auto-merge (squash) October 22, 2024 11:23
@anikdhabal anikdhabal merged commit 9382b86 into calcom:main Oct 22, 2024
51 of 57 checks passed
Copy link
Contributor

E2E results are ready!

@ponikar
Copy link
Contributor Author

ponikar commented Oct 24, 2024

Thank you so much @anikdhabal.

@ponikar
Copy link
Contributor Author

ponikar commented Oct 29, 2024

@anikdhabal We can see the Calcom app has been updated. However when we are trying to test new flow its scheduling meeting to Calcom video. Also your team didn't ask for API_KEY without this you can't communicate with our backend.

Please let me know if I have missed something from my end. Users are not able to create meetings and they are reaching out to us.

@ponikar
Copy link
Contributor Author

ponikar commented Oct 29, 2024

cc @AkMo3

@anikdhabal
Copy link
Contributor

Hey @ponikar, have you tried uninstalling and reinstalling it? Does it fall back to the call video? If the problem persists with the new flow, then I think I will check that. Also, were you able to authenticate and install the app successfully? If possible, could you please share a video of the whole flow?

@ponikar
Copy link
Contributor Author

ponikar commented Oct 29, 2024

Hi @anikdhabal
Yes I reinstalled the app, the authentication worked and yes it fallbacks to call video. We were not able to see any logs from the backend to debug this issue.

@anikdhabal
Copy link
Contributor

Thanks @ponikar will get back to this

@ponikar
Copy link
Contributor Author

ponikar commented Oct 30, 2024

@anikdhabal We noticed that your team has disabled our old application without notifying us on prior. This is important for our users. Please restore the old application till the time your team figure out the fix.

Please consider this one as priority.

@anikdhabal
Copy link
Contributor

@ponikar what do you mean by disabling the old application? Could you pls explain? Btw it's there in the app store, maybe disabled and quickly enable it for testing

@ponikar
Copy link
Contributor Author

ponikar commented Oct 30, 2024

calcom disabled our app and sent email to all our users. We have no idea why your team did this?

image

@ponikar
Copy link
Contributor Author

ponikar commented Oct 30, 2024

I am requesting you to take this a priority as this is affecting out partners. Please inform us on priority. Is there any way to reach out you via slack? This is urgent and important we can afford much delay on this.

@anikdhabal
Copy link
Contributor

anikdhabal commented Oct 30, 2024

calcom disabled our app and sent email to all our users. We have no idea why your team did this?

Ah, this one! Don’t panic; I was just working to fix the current issue in the morning. I disabled it and then enabled it again for testing.The app is there🙏. Inform it to others

Screenshot 2024-10-30 130449

@ponikar
Copy link
Contributor Author

ponikar commented Oct 30, 2024

Thanks @anikdhabal if it is possible can we talk about this on slack/discord, this is really important for us.
also what will happen now, will all users use new version?

Our new version is not working as well, its falling back to cal video. We cannot debug this from our end.

@ponikar
Copy link
Contributor Author

ponikar commented Oct 30, 2024

Can you send this confirmation email to all our existing users if possible, our users got panicked when they received this email.

@anikdhabal
Copy link
Contributor

@ponikar let's talk about it in discord. Pls share you your link

@arcinston
Copy link

arcinston commented Oct 30, 2024

hi @anikdhabal , Arush here from Huddle01 Engineering team

this email has been sent to all our addon users which has lead to user panic and lots of support tickets opening

would request you to send an email as a followup informing all users that the addon is enabled (and the prev email was a false alarm)

this would help swiftly solve this issue

@arcinston
Copy link

arcinston commented Oct 30, 2024

my username on discord : arcinston

send across a friend request and lets resolve this ASAP
thanks

link to the discord group chat : https://discord.gg/4XypmSnV

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api area: API, enterprise API, access token, OAuth app-store area: app store, apps, calendar integrations, google calendar, outlook, lark, apple calendar authentication area: authentication, auth, google sign in, password, SAML, password reset, can't log in community Created by Linear-GitHub Sync ❗️ .env changes contains changes to env variables ✨ feature New feature or request ready-for-e2e
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants