Remove outdated or incorrect users for Hub values.yaml #3500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following changes will be applied to the production Kubernetes cluster upon merge. BE AWARE this may not reveal changes that have been manually applied to the cluster getting undone—applying manual changes to the cluster should be avoided. jupyterhub, hub, Deployment (apps) has changed:
...
hub.jupyter.org/network-access-proxy-api: "true"
hub.jupyter.org/network-access-proxy-http: "true"
hub.jupyter.org/network-access-singleuser: "true"
annotations:
checksum/config-map: ecf5268b9d342e8ab7c99ede7cbfde395133c574e9a4b24e25c2e825968e8311
- checksum/secret: 48404a3a5a831ce46ea2e2805be9b8b0fe6079f20847583ebcba69d45de0f715
+ checksum/secret: 9d73c780ed16d5b1598ece4f7c6c905cd4873f53ea9bb723b5f6eddaf290ab98
spec:
tolerations:
- effect: NoSchedule
key: hub.jupyter.org/dedicated
operator: Equal
...
jupyterhub, hub, Secret (v1) has changed:
...
name: hub
data:
hub.config.ConfigurableHTTPProxy.auth_token: 'REDACTED # (64 bytes)'
hub.config.CryptKeeper.keys: 'REDACTED # (64 bytes)'
hub.config.JupyterHub.cookie_secret: 'REDACTED # (64 bytes)'
- values.yaml: '-------- # (11192 bytes)'
+ values.yaml: '++++++++ # (11166 bytes)'
type: Opaque
|
vevetron
requested changes
Oct 15, 2024
tiffanychu90
requested review from
vevetron
and removed request for
evansiroky
vevetron
approved these changes
Oct 16, 2024
|
The description doesn't match the PR but it's probably okay! This PR is just a little admin cleanup. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changing the
values.yamlrelated to JupyterHub so it can spawn up new pods as needed. Slack discussion decided we'd go down to 2 zones and 2 min nodesResolves
Type of change
How has this been tested?
Don't know how
Post-merge follow-ups
Document any actions that must be taken post-merge to deploy or otherwise implement the changes in this PR (for example, running a full refresh of some incremental model in dbt). If these actions will take more than a few hours after the merge or if they will be completed by someone other than the PR author, please create a dedicated follow-up issue and link it here to track resolution.