Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reCAPTCHA: Fix Unverified error pages #2597

Open
wants to merge 5 commits into
base: refactor/recaptcha-copy
Choose a base branch
from

Conversation

machikoyasuda
Copy link
Member

@machikoyasuda machikoyasuda commented Dec 18, 2024

closes #2596

What this PR does

  • Creates a way the unverified-error-agency-card-base.html error template for the unverified error for Agency Card templates: The headline, icon, CTA, agency links, back button all come from the template. The agency-card-specific template only now brings in the body paragraph.
  • And now unverified.html is only for the Login/Non-Login (non-agency card) error flow.

How to test

  • You can go directly to eligibility/unverified after you chose an agency and compare with the error page on prod

@machikoyasuda machikoyasuda self-assigned this Dec 18, 2024
@github-actions github-actions bot added front-end HTML/CSS/JavaScript and Django templates i18n Copy: Language files or Django i18n framework labels Dec 18, 2024
Copy link

github-actions bot commented Dec 18, 2024

Coverage report

This PR does not seem to contain any modification to coverable code.

@machikoyasuda machikoyasuda marked this pull request as ready for review December 18, 2024 23:52
@machikoyasuda machikoyasuda requested a review from a team as a code owner December 18, 2024 23:52
@@ -16,19 +16,18 @@
{% endblock icon %}

{% block headline-text %}
{% translate "Your eligibility could not be verified." %}
Copy link
Member

@angela-tran angela-tran Dec 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But I don't see how or when there would be a scenario in which there wouldn't be agency card-specific headline and body text, so I removed the default body text for paragraphs. And since all the error pages have the same headline-text across the agency cards, I set that text in unverified.html and removed it from the agency-specific pages.

  • But if my assumptions above are not correct, let me know!

I believe we still need this copy and the "That's okay!... " copy for when a user is not eligible for a non-agency card flow.

Figma:
image

https://www.figma.com/design/SeSd3LaLd6WkbEYhmtKpO3/Benefits-(Full-Application)?node-id=9234-110446&m=dev

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sidenote: there's an outdated screen in Figma... right below those "Login" and "Non-Login" screens, it's showing that agency cards are supposed to have the old screen. But higher up in the file, it shows the new screen.

image

See #2013 and #2053 where the new screen replaced the old one for agency cards.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh thank you for this clairification! Will fix.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay I fixed it with a new approach, that I hope is more clear:

  • unverified.html is for the Login flow
  • unverified-error-agency-base is for all agency card flows
    Updated Spanish for the unverified page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
front-end HTML/CSS/JavaScript and Django templates i18n Copy: Language files or Django i18n framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants