-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
reCAPTCHA: Fix Unverified error pages #2597
base: refactor/recaptcha-copy
Are you sure you want to change the base?
reCAPTCHA: Fix Unverified error pages #2597
Conversation
@@ -16,19 +16,18 @@ | |||
{% endblock icon %} | |||
|
|||
{% block headline-text %} | |||
{% translate "Your eligibility could not be verified." %} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But I don't see how or when there would be a scenario in which there wouldn't be agency card-specific headline and body text, so I removed the default body text for
paragraphs
. And since all the error pages have the sameheadline-text
across the agency cards, I set that text inunverified.html
and removed it from the agency-specific pages.
- But if my assumptions above are not correct, let me know!
I believe we still need this copy and the "That's okay!... " copy for when a user is not eligible for a non-agency card flow.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ahh thank you for this clairification! Will fix.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay I fixed it with a new approach, that I hope is more clear:
unverified.html
is for the Login flowunverified-error-agency-base
is for all agency card flows
Updated Spanish for theunverified
page.
…x copy for unverified login/nonlogin
closes #2596
What this PR does
unverified-error-agency-card-base.html
error template for the unverified error for Agency Card templates: The headline, icon, CTA, agency links, back button all come from the template. The agency-card-specific template only now brings in the body paragraph.unverified.html
is only for the Login/Non-Login (non-agency card) error flow.How to test
eligibility/unverified
after you chose an agency and compare with the error page on prod