Feat: customize the login form using an environment variable #2361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
deployment-dev
Coverage report
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||
| @@ -72,7 +72,7 @@ def RUNTIME_ENVIRONMENT(): | |||
| "https://www.googleapis.com/auth/userinfo.email", | |||
| "https://www.googleapis.com/auth/userinfo.profile", | |||
| ] | |||
| SSO_SHOW_FORM_ON_ADMIN_PAGE = False | |||
| SSO_SHOW_FORM_ON_ADMIN_PAGE = os.environ.get("SSO_SHOW_FORM_ON_ADMIN_PAGE", "False").lower() == "true" | |||
There was a problem hiding this comment.
angela-tran
requested changes
Sep 12, 2024
lalver1
force-pushed
the
feat/sso-form-setting
branch
from
f563041 to
f87965b
Compare
lalver1
force-pushed
the
feat/sso-form-setting
branch
from
f87965b to
27a98fb
Compare
angela-tran
approved these changes
Sep 12, 2024
|
It's interesting @angela-tran , looks like commas are not required according to the terraform docs since app_settings are a key-value pair, but it's prob best to include them (it also makes the VS Code syntax highlighting look uniform). |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR sets the login form configuration using an environment variable.
Before merging this PR, ensure that:
devhas a new secret in the key vault and a new environment variable that refers to this secret in the app settingstesthas a new secret in the key vault and a new environment variable that refers to this secret in the app settingsprodhas a new secret in the key vault and a new environment variable that refers to this secret in the app settings