Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: custom submitting event for form button effects #1112

Merged
merged 1 commit into from
Nov 2, 2022
Merged

Fix: custom submitting event for form button effects #1112

merged 1 commit into from
Nov 2, 2022

Conversation

thekaveman
Copy link
Member

Closes #1111

@thekaveman
fix(forms): custom submitting event for button effects
d8f14d4 
HTMLFormElement.requestSubmit() is not yet widely implemented,
specifically not in iPhone Safari 15.x
@thekaveman thekaveman requested a review from a team as a code owner November 1, 2022 22:56
@github-actions github-actions bot added deployment-dev [auto] Changes that will trigger a deploy if merged to dev front-end HTML/CSS/JavaScript and Django templates labels Nov 1, 2022
@thekaveman
Copy link
Member Author

@machikoyasuda since you were able to reproduce on your Macbook, can you please test/review this PR and see if it fixes the issue for you?

I've confirmed that the existing behavior is maintained on Windows + Chrome/FF:

  • reCAPTCHA configured
  • HTML5 validation works
  • form submits correctly

machikoyasuda
machikoyasuda approved these changes Nov 1, 2022
View reviewed changes
Copy link
Member

@machikoyasuda machikoyasuda left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on Safari 15 on Desktop - with recaptcha, with validation, form submit for both the 1st and 2nd form

Will test on Dev on my Phone after merge

@thekaveman thekaveman merged commit cf2729c into dev Nov 2, 2022
@thekaveman thekaveman deleted the fix/form-submit branch November 2, 2022 00:14
@thekaveman
Copy link
Member Author

@machikoyasuda this change is deployed and live in dev

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@machikoyasuda machikoyasuda machikoyasuda approved these changes

Assignees
No one assigned
Labels
deployment-dev [auto] Changes that will trigger a deploy if merged to dev front-end HTML/CSS/JavaScript and Django templates
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

HTMLFormElement.requestSubmit lacks browser support
2 participants
@thekaveman @machikoyasuda