Give up the GIL during Starlark execution #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I had some weird ideas about the GIL that I cleared up today. This removes an unneccesary GIL lock in one spot, and changes `exec` and `eval` to give up the GIL while they're busy executing Starlark code. A mutex is added per Starlark thread to prevent multiple Python threads from trying to access the same Starlark thread at once. Also removed a couple unneccesary Cgo wrappers where I could use the Python API directly instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had some weird ideas about the GIL that I cleared up today. This
removes an unneccesary GIL lock in one spot, and changes
execandevalto give up the GIL while they're busy executing Starlark code.A mutex is added per Starlark thread to prevent multiple Python threads
from trying to access the same Starlark thread at once.
Also removed a couple unneccesary Cgo wrappers where I could use the
Python API directly instead.