Add filename to exec/eval and parse to eval
#26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These methods now accept a `filename` parameter, which will be used to set the `filename` attribute on any resulting `SyntaxError` objects. `eval` now accepts a `parse` parameter; if it is not True, then eval will return a string containing the unparsed expression. This also adds a bunch of tests for parsing, in preparation for moving away from ast.literal_eval and building Python data structures directly in a subsequent pull request.
jordemort
added a commit
that referenced
this pull request
Apr 18, 2022
In #26 another change snuck in to retain the globals across multiple calls to exec, so that it could be used to define multiple things. While writing a test for this behavor, I discovered that it is possible for starlark-go's Eval to return a resolve.ErrorList, in addition to a starlark.EvalError or a syntax.Error, so I had to add handling for that as well.
jordemort
added a commit
that referenced
this pull request
Apr 18, 2022
In #26 another change snuck in to retain the globals across multiple calls to exec, so that it could be used to define multiple things. While writing a test for this behavor, I discovered that it is possible for starlark-go's Eval to return a resolve.ErrorList, in addition to a starlark.EvalError or a syntax.Error, so I had to add handling for that as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These methods now accept a
filenameparameter, which will be used toset the
filenameattribute on any resultingSyntaxErrorobjects.evalnow accepts aparseparameter; if it is not True, then evalwill return a string containing the unparsed expression.
This also adds a bunch of tests for parsing, in preparation for moving
away from ast.literal_eval and building Python data structures directly
in a subsequent pull request.