Fix fatal error on PHP 8.4 #467
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm trying to use cakephp 4.x with php 8.4 and but this signature is causing problems. `Fatal error: Declaration of Cake\Chronos\Traits\FactoryTrait::createFromTimestamp(int $timestamp, $tz = null): Cake\Chronos\ChronosInterface must be compatible with DateTimeImmutable::createFromTimestamp(int|float $timestamp): static`
gersonfs
commented
Nov 18, 2024
| @@ -336,7 +336,8 @@ public static function createFromArray(array $values): ChronosInterface | |||
| * @param \DateTimeZone|string|null $tz The DateTimeZone object or timezone name the new instance should use. | |||
| * @return static | |||
| */ | |||
| public static function createFromTimestamp(int $timestamp, $tz = null): ChronosInterface | |||
| #[ReturnTypeWillChange] | |||
| public static function createFromTimestamp(int|float $timestamp, $tz = null): ChronosInterface | |||
There was a problem hiding this comment.
Oops, we have tests for php 7.4, any suggestions on how to maintain compatibility?
|
This was only fixed in Chronos v3 as you can see here: I'd recommend upgrading to CakePHP 5 before trying to get CakePHP 4 running with PHP 8.4 With that you will get Chronos v3 and therefore the fix for PHP 8.4 |
|
Ok, I'll have more work but that's it. Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm trying to use cakephp 4.x with php 8.4 and but this signature is causing problems.
https://php.watch/versions/8.4/datetime-createFromTimestamp
Fatal error: Declaration of Cake\Chronos\Traits\FactoryTrait::createFromTimestamp(int $timestamp, $tz = null): Cake\Chronos\ChronosInterface must be compatible with DateTimeImmutable::createFromTimestamp(int|float $timestamp): static