Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change brings the enum / contents pattern to the Text object, breaking its monolithic declaration into multiple mods and structs. This comes with a host of ergonomics improvements, like lots of handy conversions - for example if there is an fn of type
fn foo(text: impl Into<text::Plain>) -> Foo
, you can invoke it with atext::Plain
, a string literal, or aString
.BREAKING!:
text
is now an enum of single-element tuples. Those tuples point to separate structure definitions for the different kinds of Text objects.BREAKING!:
text
is now publicly used at the crate root, breaking glob imports likeslack_blocks::*
if there's a local code element namedtext