Haven update dependencies #1636
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With Haven 4, Oracle prices contain XUSD spot rates. Additionally, all rates are now passed in a consistent manner, with the USD equivalent, so there is no need to apply special logic for XUSD anymore.
when sending all, amount is set to null, which requires a nullable String
amount should be a nullable String
Haven 4 update
MrCyjaneK
reviewed
Aug 23, 2024
|
|
||
| - if: ${{ steps.cache-externals.outputs.cache-hit != 'true' }} | ||
| name: Generate Externals | ||
| run: | | ||
| cd /opt/android/cake_wallet/scripts/android/ | ||
| source ./app_env.sh cakewallet | ||
| ./build_monero_all.sh |
There was a problem hiding this comment.
I think that we need both
|
Please consider incorporating #1652 before merging this PR into main. Haven will have a hardfork on 28.08.2024, and upgrade to Haven 4.1.0 is required. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original PR #1540
This PR aims to achieve the following goals:
Enable the build of Cake Wallet with Haven 4.0 for Android
Adapt Cake Wallet to properly handle the new Haven Oracle format
Fix a bug in Cake Wallet which prevented the "Send ALL" functionality to work properly
This is achieved by:
Switching to Haven 4.0.2 in the build_haven.sh script. On Haven side, in Haven 4.0.2 the changes necessary to integrate again with Cake were already done.
Adding cryptonote_format_utils_bacis to the linking process
Remove unnecessary transformations in update_haven_rate.dart
Change data types so that "amount" can be a nullable String, required when using "Send ALL"
How was this tested:
Build process was tested under Debian on x86_64 architecture, with flutter and ndk in line with the Cake Wallet documentation
Functional tests Cake Wallet were performed using Waydroid on x86_64
Syncing works, proper balances and transactions were displayed, transfers of XHV, XUSD and XAU were tested and work
Special considerations:
INSTALL_VENDORED_LIBUNBOUND doesn't seem to work in my environment properly, so I added the copy of unbound to the haven folder in copy_monero_deps.sh. This is not part of the commits.
Out of scope:
No tests of builds for IOS were performed, due to lack of proper environment for them. No adaptations were done to IOS build process apart from bumping the Haven version, due to lack of proper environment.
Dependencies were not updated, but this will come in a separate PR. The reason for splitting this in two parts is to give you a chance to not perform these dependency updates at first, especially given that I am not sure how difficult it would be to perform the same steps for ios. However, in this PR, expat, openssl, sodium, zeromq will be bumped to the versions also used by the latest Monero release.