Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Non Deterministic error shown in NuGet Package Explorer #48

Closed
gep13 opened this issue Jul 4, 2020 · 1 comment
Closed

Fix Non Deterministic error shown in NuGet Package Explorer #48

gep13 opened this issue Jul 4, 2020 · 1 comment
Assignees
@gep13
Labels
Improvement
Milestone
5.2.0

Comments

@gep13
Copy link
Member

gep13 commented Jul 4, 2020

image

This will actually be fixed upstream in Cake.Recipe, and then brought into this repository.
@gep13 gep13 added this to the 5.2.0 milestone Jul 4, 2020
@gep13 gep13 self-assigned this Jul 4, 2020
gep13 added a commit that referenced this issue Jul 4, 2020
@gep13
(GH-48) Update to latest Cake.Recipe
6443f2f 
This includes new defaults for "where" to push packages to, so this
doesn't need to be set on each project, also includes work to ensure
determinstic packages.
gep13 added a commit that referenced this issue Jul 4, 2020
@gep13
(GH-48) Update to latest Cake.Recipe
e8b3659
gep13 added a commit that referenced this issue Jul 4, 2020
@gep13
(GH-48) Update to latest Cake.Recipe
67edee2
gep13 added a commit that referenced this issue Jul 4, 2020
@gep13
(GH-48) Update to latest Cake.Recipe
ab8d79b
gep13 added a commit that referenced this issue Jul 4, 2020
@gep13
(GH-48) Enable SourceLink for Test project
0e08563 
So that NuGet package can be correctly created in a deterministic way.
gep13 added a commit that referenced this issue Jul 4, 2020
@gep13
(GH-48) Switch to using coverlet
b5747fb 
Rather than using OpenCover, which doesn't support deterministic builds.
gep13 added a commit that referenced this issue Jul 4, 2020
@gep13
(GH-48) Remove unnecessary file
ab25121 
This was added as it was believed that this was needed, but after
further testing, it isn't required.
@gep13 gep13 closed this as completed Jul 4, 2020
gep13 added a commit that referenced this issue Jul 5, 2020
@gep13
(GH-48) Add workaround for coverlet
a2097ed 
This is mentioned here:

https://github.com/coverlet-coverage/coverlet/blob/master/Documentation/DeterministicBuild.md
gep13 added a commit that referenced this issue Jul 5, 2020
@gep13
Revert "(GH-48) Add workaround for coverlet"
da5a409 
This reverts commit a2097ed.
@cake-contrib-bot
Copy link

🎉 This issue has been resolved in version 5.2.0 🎉

The release is available on:

Your GitReleaseManager bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gep13 gep13

Labels
Improvement
Projects
None yet
Milestone
5.2.0
Development

No branches or pull requests
2 participants
@gep13 @cake-contrib-bot