Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Passwords should not be visible in the build log #24

Closed
ecampidoglio opened this issue Mar 7, 2019 · 1 comment
Closed

Passwords should not be visible in the build log #24

ecampidoglio opened this issue Mar 7, 2019 · 1 comment
Assignees
@ecampidoglio
Labels
bug
Milestone
4.1

Comments

@ecampidoglio
Copy link
Member

ecampidoglio commented Mar 7, 2019 •
edited
Loading

The password specified in the CurlSettings.Password property is clearly visible in the log when running the build script with the verbosity level set to Diagnostic.

Since passwords are sensitive information, they should be redacted from the build output.
@ecampidoglio ecampidoglio added this to the 4.1 milestone Mar 7, 2019
@ecampidoglio ecampidoglio self-assigned this Mar 7, 2019
ecampidoglio added a commit that referenced this issue Mar 7, 2019
@ecampidoglio
Redacts passwords from the build log (#24)
8e24a9a
@ecampidoglio
Copy link
Member Author

Fixed. As of 8e24a9a the build output is:

Executing: /usr/bin/curl --user "username:[REDACTED]" <url>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ecampidoglio ecampidoglio

Labels
bug
Projects
None yet
Milestone
4.1
Development

No branches or pull requests
1 participant
@ecampidoglio