(#4322) Removed check for OS on PathHelper.IsRooted #4323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devlead
force-pushed
the
feature/GH-4322
branch
from
eace232
to
8d390fa
Compare
|
@nils-a your changes have been merged, thanks for your contribution 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the check for the currently running platform/OS before checking whether the path is a windows path, beginning with a drive letter.
fixes #4322
Rationale:
I feel
Pathshould be a very agnostic "thing" andC:\temp\should be a valid (and "absolute") path on any system, even if, if I were to use it on my linux system, it would simply not work. (Probably it would, somehow, but that's besides my point.)My guess is, that while this is not a breaking change in API/ABI, it is a breaking change in "meaning" - even if I think most likely no-one is relying on the fact that currently
C:\tempis an absolute path, if cake is running on a windows system and a relative path if cake is not running on a windows system.