Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for empty properties in dotnet msbuild #4165

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

Zulu-Inuoe
Copy link

Fixes #4158

@Zulu-Inuoe
Copy link
Author

@microsoft-github-policy-service agree

@augustoproiete augustoproiete self-requested a review June 6, 2023 04:24
Copy link
Member

@augustoproiete augustoproiete left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @Zulu-Inuoe

Overall looks good, but there's at least one test failing (which expects the old behavior). Could you take a look and amend the test(s) (or delete if doesn't make sense anymore)?

Actual:   (null)
  Stack Trace:
     at Cake.Common.Tests.Unit.Tools.DotNet.MSBuild.DotNetMSBuildBuilderTests.TheBuildMethod.Should_Throw_If_Property_Has_No_Value(String[] propertyValues) in D:\a\1\s\src\Cake.Common.Tests\Unit\Tools\DotNet\MSBuild\DotNetMSBuildBuilderTests.cs:line 204
   at System.RuntimeMethodHandle.InvokeMethod(Object target, Void** arguments, Signature sig, Boolean isConstructor)
   at System.Reflection.MethodInvoker.Invoke(Object obj, IntPtr* args, BindingFlags invokeAttr)
  Failed Cake.Common.Tests.Unit.Tools.DotNet.MSBuild.DotNetMSBuildBuilderTests+TheBuildMethod.Should_Throw_If_Property_Has_No_Value(propertyValues: [""]) [< 1 ms]
  Error Message:
   Assert.IsType() Failure
Expected: System.ArgumentException

@augustoproiete
Copy link
Member

Hey @Zulu-Inuoe just following up on this one. Will you be able to get this to the finish line?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot specify empty properties when using DotNetBuild
2 participants