GH3138: Add Settings_Color configuration option #2999
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
augustoproiete
force-pushed
the
add-settings_color-configuration-option
branch
from
da7bc62
to
df6bacb
Compare
augustoproiete
force-pushed
the
add-settings_color-configuration-option
branch
from
df6bacb
to
1eb74af
Compare
augustoproiete
force-pushed
the
add-settings_color-configuration-option
branch
from
1eb74af
to
22f73d0
Compare
augustoproiete
changed the title
gep13
changed the title
|
Meeting of 2022-06-12 - We decided that it's OK to write to the Console in case of errors reading the configuration |
This comment was marked as spam.
This comment was marked as spam.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP. Opening a draft PR for feedback at this point to discuss next steps as this seems to require change on the timing when the Cake configuration is read.
Adding this new configuration option requires access to
ICakeConfigurationat a much earlier stage in the Cake run lifecycle, more specifically at the time of resolution ofDefaultCommandgiven that it needs anICakeLogwhich in turn requires anIConsoleRenderer- and at this point the decision about ANSI vs non-ANSI console is made.Does it make sense to register an
ICakeConfigurationsingleton at the very start, instead of reading the config later during bootstrapping or building, or is there a better way?