Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH2487: Add alias dupe check on method/property signarture #2488

Merged
merged 1 commit into from
Feb 27, 2019

Conversation

devlead
Copy link
Member

@devlead devlead commented Feb 24, 2019

Fixes #2487

Copy link
Member

@patriksvensson patriksvensson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me but left some minor comments 👍

src/Cake/Scripting/Roslyn/RoslynCodeGenerator.cs Outdated Show resolved Hide resolved
src/Cake.Core/Scripting/CodeGen/PropertyAliasGenerator.cs Outdated Show resolved Hide resolved
src/Cake.Core/Scripting/Script.cs Outdated Show resolved Hide resolved
src/Cake/Scripting/Roslyn/RoslynScriptSession.cs Outdated Show resolved Hide resolved
@devlead devlead changed the title PoC (GH-2487) fix GH-2487: Add alias dupe check on method/property signarture Feb 26, 2019
@devlead devlead marked this pull request as ready for review February 26, 2019 20:56
@devlead
Copy link
Member Author

devlead commented Feb 26, 2019

@patriksvensson feedback addressed, removed WIP.

@gep13 gep13 changed the title GH-2487: Add alias dupe check on method/property signarture GH2487: Add alias dupe check on method/property signarture Feb 27, 2019
@devlead devlead force-pushed the feature/gh-2487 branch 2 times, most recently from ee14928 to 18e6b04 Compare February 27, 2019 10:30
@patriksvensson patriksvensson merged commit f169ae6 into cake-build:develop Feb 27, 2019
@patriksvensson
Copy link
Member

Merged! Thank you for your contribution. Much appreciated! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants