Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH820: Add global override to show process command-line #2486

Merged
merged 1 commit into from
Feb 27, 2019

Conversation

gitfool
Copy link
Contributor

@gitfool gitfool commented Feb 22, 2019

Following up from #2457, I can cleanly address #820 with a global setting that temporarily overrides the process runner log level.

Example usage:

$env:Cake_Settings_ShowProcessCommandLine='true';  .\build.ps1

src/Cake.Core/IO/ProcessRunner.cs Outdated Show resolved Hide resolved
@gitfool
Copy link
Contributor Author

gitfool commented Feb 27, 2019

@devlead your suggestion worked, of course, so changed as requested.

Copy link
Member

@devlead devlead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@devlead devlead merged commit 1765ffa into cake-build:develop Feb 27, 2019
@devlead
Copy link
Member

devlead commented Feb 27, 2019

@gitfool your changes have been merged, thanks for your contribution 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants